Skip to content

Conversation

@gitforwindowshelper
Copy link

Signed-off-by: Matthias Aßhauer <mha1993@live.de>
@rimrul rimrul marked this pull request as ready for review December 4, 2025 17:14
@rimrul
Copy link
Member

rimrul commented Dec 4, 2025

/deploy

The workflow run was started.

@rimrul
Copy link
Member

rimrul commented Dec 4, 2025

'Expiration time' claim ('exp') is too far in the future

what do you mean GitHub?

@rimrul
Copy link
Member

rimrul commented Dec 4, 2025

Ah, this: https://github.com/git-for-windows/git-for-windows-automation/blob/a8955675901a77b42853ef36fe13722a9a657fa1/github-api-request-as-app.js#L9-L16

The exp property "must be no more than 10 minutes into the future", but we'll probably need to account for clock drift here, too. GitHub recommends to set the iat property "60 seconds in the past", "to protect against clock drift", but exp probably needs some protection, too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[New mingw-w64-llvm version] llvm: update to 21.1.7 (#26686)

2 participants