Add local exercise repo fetching for testing local changes #40
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
This pull request adds support for using local exercise repositories for testing, enabling developers to test exercise changes locally before pushing to remote. The implementation maintains backwards compatibility by defaulting to "remote" type when the type field is absent.
Changes:
- Extended
ExercisesSourcedataclass to support both "remote" and "local" repository types with appropriate fields for each - Added
from_rawclass method for flexible deserialization with backwards compatibility - Implemented local repository copying logic using
shutil.copytreefor isolation
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 6 comments.
| File | Description |
|---|---|
| app/configs/gitmastery_config.py | Extended ExercisesSource to support local/remote types, added from_raw factory method for backwards-compatible deserialization |
| app/utils/gitmastery.py | Added local repo handling branch in enter method with path validation and directory copying logic |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Typecheck `path` beofre use - Remove symlink copying - Clarify legacy fallthrough
Collaborator
|
@VikramGoyal23 Is this ready for review? Would also be good to resolve copilot comments if they have been addressed as well to reduce cognitive load on reviewer |
Contributor
Author
|
@jovnc Yes, this is ready for another review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows developers to set the exercise source as a local path, enabling fully local exercise testing. Backwards compatible and assumes lack of
typefield asremote.