Skip to content

[Bugfix] Better handling of unapproved grants in Grants Explorer #3731

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MasterHW merged 1 commit into from
Dec 9, 2024
Merged

[Bugfix] Better handling of unapproved grants in Grants Explorer #3731

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 10 additions & 4 deletions packages/grant-explorer/src/features/round/ViewProjectDetails.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,11 @@ export default function ViewProjectDetails() {
applicationId = paramApplicationId;
}

const { data: application, error } = useApplication(
const {
data: application,
error,
isLoading,
} = useApplication(
{
chainId: Number(chainId as string),
roundId,
Expand Down Expand Up @@ -230,7 +234,7 @@ export default function ViewProjectDetails() {
),
},
],
[stats, grants, projectToRender, description]
[stats, grants, projectToRender, description, isLoading]
);

const handleTabChange = (tabIndex: number) => {
Expand Down Expand Up @@ -283,7 +287,9 @@ export default function ViewProjectDetails() {
/>
)}
<div className="flex-1">
{error === undefined ? (
{error === undefined &&
!isLoading &&
projectToRender !== undefined ? (
<>
<Skeleton isLoaded={Boolean(title)}>
<h1 className="text-4xl font-modern-era-medium tracking-tight text-grey-500">
Expand All @@ -301,7 +307,7 @@ export default function ViewProjectDetails() {
</div>
</>
) : (
<p>Couldn't load project data.</p>
<p>Couldn't load project data. It may not exist.</p>
)}
</div>
</div>
Expand Down
Loading