feat: Add Enterprise Runners support#4843
Draft
micr0zz wants to merge 41 commits intogithub-aws-runners:mainfrom
Draft
feat: Add Enterprise Runners support#4843micr0zz wants to merge 41 commits intogithub-aws-runners:mainfrom
micr0zz wants to merge 41 commits intogithub-aws-runners:mainfrom
Conversation
This reverts commit c108a83. # Conflicts: # README.md # modules/multi-runner/README.md # modules/runners/job-retry/README.md
# Conflicts: # README.md # modules/multi-runner/README.md # modules/runners/job-retry/README.md
Member
|
@micr0zz thx, great you working on supporting enterprise level runners. I have not digged in detail in your PR. But quickly scanned the PR. I think we should introduce breaking changes to support enterprise. this to avoid configuration is getting super complex. What I mean here moving away from Also wonderig what the status is of the PR. Still in WIP? In that case ca you mark the PR as draft. |
Member
|
@micr0zz I moved the PR to draft, it seems still in WIP. Are you still working on this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is to add support for Enterprise level runners. Although GitHub supports applications at enterprise level, this type of authentication cannot be used for most of the requests (register runner/get runner, etc...).
WIP