Add listEC2Runners verification to maximum runners test#4980
Merged
stuartp44 merged 3 commits intostu/fix_job_retryfrom Jan 5, 2026
Merged
Add listEC2Runners verification to maximum runners test#4980stuartp44 merged 3 commits intostu/fix_job_retryfrom
stuartp44 merged 3 commits intostu/fix_job_retryfrom
Conversation
Co-authored-by: stuartp44 <1926002+stuartp44@users.noreply.github.com>
Co-authored-by: stuartp44 <1926002+stuartp44@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Update job retry mechanism based on feedback from previous PR
Add listEC2Runners verification to maximum runners test
Jan 5, 2026
stuartp44
approved these changes
Jan 5, 2026
Contributor
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
Brend-Smits
pushed a commit
that referenced
this pull request
Jan 12, 2026
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: stuartp44 <1926002+stuartp44@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The test
'calls publishRetryMessage even when maximum runners is reached'was missing verification thatlistEC2Runnersis called when checking runner limits.Changes
listEC2Runnersis called with correct parameters whenRUNNERS_MAXIMUM_COUNT='0'toHaveBeenCalledWithmatcher for consistency with modern Vitest practicesAccording to the scale-up logic (scale-up.ts:370-371), when
maximumRunnersis not -1,listEC2Runnersmust be called to get the current runner count. The test now verifies this behavior occurs as expected:💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.