C++: Fix queries I forgot after merging github/codeql#20485.

[MathiasVP]

Description

The changes in #958 weren't enough to fixup the Coding Standards queries after we merged github/codeql#20485. This PR fixes those missing queries.

Change request type

• Release or process automation (GitHub workflows, internal scripts)
• Internal documentation
• External documentation
• Query files (.ql, .qll, .qls or unit tests)
• External scripts (analysis report or other code shipped as part of a release)

Rules with added or modified queries

• No rules added
• Queries have been added for the following rules:
  • rule number here
• Queries have been modified for the following rules:
  • rule number here

Release change checklist

A change note (development_handbook.md#change-notes) is required for any pull request which modifies:

• The structure or layout of the release artifacts.
• The evaluation performance (memory, execution time) of an existing query.
• The results of an existing query in any circumstance.

If you are only adding new rule queries, a change note is not required.

Author: Is a change note required?

• Yes
• No

🚨🚨🚨
Reviewer: Confirm that format of shared queries (not the .qll file, the
.ql file that imports it) is valid by running them within VS Code.

• Confirmed

Reviewer: Confirm that either a change note is not required or the change note is required and has been added.

• Confirmed

Query development review checklist

For PRs that add new queries or modify existing queries, the following checklist should be completed by both the author and reviewer:

Author

• Have all the relevant rule package description files been checked in?
• Have you verified that the metadata properties of each new query is set appropriately?
• Do all the unit tests contain both "COMPLIANT" and "NON_COMPLIANT" cases?
• Are the alert messages properly formatted and consistent with the style guide?
• Have you run the queries on OpenPilot and verified that the performance and results are acceptable?
  As a rule of thumb, predicates specific to the query should take no more than 1 minute, and for simple queries be under 10 seconds. If this is not the case, this should be highlighted and agreed in the code review process.
• Does the query have an appropriate level of in-query comments/documentation?
• Have you considered/identified possible edge cases?
• Does the query not reinvent features in the standard library?
• Can the query be simplified further (not golfed!)

Reviewer

• Have all the relevant rule package description files been checked in?
• Have you verified that the metadata properties of each new query is set appropriately?
• Do all the unit tests contain both "COMPLIANT" and "NON_COMPLIANT" cases?
• Are the alert messages properly formatted and consistent with the style guide?
• Have you run the queries on OpenPilot and verified that the performance and results are acceptable?
  As a rule of thumb, predicates specific to the query should take no more than 1 minute, and for simple queries be under 10 seconds. If this is not the case, this should be highlighted and agreed in the code review process.
• Does the query have an appropriate level of in-query comments/documentation?
• Have you considered/identified possible edge cases?
• Does the query not reinvent features in the standard library?
• Can the query be simplified further (not golfed!)

[Copilot]

Pull Request Overview

This PR fixes Coding Standards queries that were missed in the previous update after merging GitHub CodeQL#20485, which appears to have changed how guard conditions are handled in the CodeQL library.

• Updates guard condition checks to use the new valueControlsEdge API instead of the deprecated getAChild*() pattern
• Adjusts related test expectations to account for the API changes
• Ensures implicit comparison detection properly uses the new guard condition interface

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
UnsignedOperationWithConstantOperandsWraps.qll	Updates guard condition check to use valueControlsEdge API
FunctionErroneousReturnValueNotTested.qll	Simplifies guard condition check using new API
DetectAndHandleMemoryAllocationErrors.expected	Updates test expectations for line number changes
DetectAndHandleMemoryAllocationErrors.ql	Refactors guard condition logic for nothrow allocation checking
IntegerExpressionLeadToDataLoss.ql	Updates guard condition check to use valueControlsEdge API
DoNotCompareFunctionPointersToConstantValues.ql	Fixes implicit comparison detection with proper guard condition check

---

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}