Update javascript/ql/src/experimental/Security/CWE-614/InsecureCookie.qll

dellalibera · esbena · web-flow · commit 3bd7615a7516 · 2020-08-26T01:47:37.000+02:00
Co-authored-by: Esben Sparre Andreasen &lt;esbena@github.com&gt;
diff --git a/javascript/ql/src/experimental/Security/CWE-614/InsecureCookie.qll b/javascript/ql/src/experimental/Security/CWE-614/InsecureCookie.qll
@@ -75,7 +75,7 @@ module Cookie {
   /**
    * A cookie set using `response.cookie` from `express` module (https://expressjs.com/en/api.html#res.cookie).
    */
-  class InsecureExpressCookieResponse extends Cookie {
+  class InsecureExpressCookieResponse extends Cookie, DataFlow::MethodCallNode {
     InsecureExpressCookieResponse() {
       this.calls(any(Express::ResponseExpr r).flow(), "cookie")
     }

Original file line number	Diff line number	Diff line change
`@@ -75,7 +75,7 @@ module Cookie {`
`75`	`75`	`/**`
`76`	`76`	* A cookie set using `response.cookie` from `express` module (https://expressjs.com/en/api.html#res.cookie).
`77`	`77`	`*/`
`78`		`- class InsecureExpressCookieResponse extends Cookie {`
	`78`	`+ class InsecureExpressCookieResponse extends Cookie, DataFlow::MethodCallNode {`
`79`	`79`	`InsecureExpressCookieResponse() {`
`80`	`80`	`this.calls(any(Express::ResponseExpr r).flow(), "cookie")`
`81`	`81`	`}`