C#: Clean up dependencies Newtonsoft.Json and dont override nowarn.

michaelnebel · michaelnebel · commit 4e079d34b9bc · 2024-12-06T15:55:30.000+01:00
diff --git a/csharp/autobuilder/Semmle.Autobuild.CSharp/BUILD.bazel b/csharp/autobuilder/Semmle.Autobuild.CSharp/BUILD.bazel
@@ -17,6 +17,5 @@ codeql_csharp_binary(
         "//csharp/extractor/Semmle.Extraction.CSharp.Standalone:bin/Semmle.Extraction.CSharp.Standalone",
         "//csharp/extractor/Semmle.Util",
         "@paket.main//microsoft.build",
-        "@paket.main//newtonsoft.json",
     ],
 )
diff --git a/csharp/autobuilder/Semmle.Autobuild.CSharp/paket.references b/csharp/autobuilder/Semmle.Autobuild.CSharp/paket.references
@@ -1,2 +1 @@
-Newtonsoft.Json
 Microsoft.Build
diff --git a/csharp/extractor/Semmle.Extraction.CSharp.DependencyFetching/BUILD.bazel b/csharp/extractor/Semmle.Extraction.CSharp.DependencyFetching/BUILD.bazel
@@ -11,10 +11,10 @@ codeql_csharp_library(
     ]),
     allow_unsafe_blocks = True,
     internals_visible_to = ["Semmle.Extraction.Tests"],
-    nowarn = ["CA1822"],
     visibility = ["//csharp:__subpackages__"],
     deps = [
         "//csharp/extractor/Semmle.Extraction.CSharp",
         "//csharp/extractor/Semmle.Util",
+        "@paket.main//newtonsoft.json",
     ],
 )
diff --git a/csharp/extractor/Semmle.Extraction.CSharp.DependencyFetching/paket.references b/csharp/extractor/Semmle.Extraction.CSharp.DependencyFetching/paket.references
@@ -0,0 +1 @@
+Newtonsoft.Json

Original file line number	Diff line number	Diff line change
`@@ -17,6 +17,5 @@ codeql_csharp_binary(`
`17`	`17`	`"//csharp/extractor/Semmle.Extraction.CSharp.Standalone:bin/Semmle.Extraction.CSharp.Standalone",`
`18`	`18`	`"//csharp/extractor/Semmle.Util",`
`19`	`19`	`"@paket.main//microsoft.build",`
`20`		`- "@paket.main//newtonsoft.json",`
`21`	`20`	`],`
`22`	`21`	`)`