Skip to content

Commit 680a6eb

Browse files
committed
Python: Refactor argument matching (more)
1 parent eff4745 commit 680a6eb

File tree

1 file changed

+3
-11
lines changed
  • python/ql/src/experimental/semmle/python/frameworks

1 file changed

+3
-11
lines changed

python/ql/src/experimental/semmle/python/frameworks/Stdlib.qll

Lines changed: 3 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -266,17 +266,11 @@ private module Stdlib {
266266
}
267267

268268
/** Gets the ControlFlowNode for the `args` argument, if any. */
269-
private ControlFlowNode get_args_arg() {
270-
result = node.getArg(0)
271-
or
272-
result = node.getArgByName("args")
273-
}
269+
private ControlFlowNode get_args_arg() { result in [node.getArg(0), node.getArgByName("args")] }
274270

275271
/** Gets the ControlFlowNode for the `shell` argument, if any. */
276272
private ControlFlowNode get_shell_arg() {
277-
result = node.getArg(8)
278-
or
279-
result = node.getArgByName("shell")
273+
result in [node.getArg(8), node.getArgByName("shell")]
280274
}
281275

282276
private boolean get_shell_arg_value() {
@@ -298,9 +292,7 @@ private module Stdlib {
298292

299293
/** Gets the ControlFlowNode for the `executable` argument, if any. */
300294
private ControlFlowNode get_executable_arg() {
301-
result = node.getArg(2)
302-
or
303-
result = node.getArgByName("executable")
295+
result in [node.getArg(2), node.getArgByName("executable")]
304296
}
305297

306298
override DataFlow::Node getCommand() {

0 commit comments

Comments
 (0)