Fix FPs and typo

joefarebrother · joefarebrother · commit 71d1179877a8 · 2025-07-01T16:39:12.000+01:00
diff --git a/python/ql/src/Classes/CallsToInitDel/MethodCallOrder.qll b/python/ql/src/Classes/CallsToInitDel/MethodCallOrder.qll
@@ -8,7 +8,7 @@ predicate multipleCallsToSuperclassMethod(Function meth, Function calledMulti, s
   exists(DataFlow::MethodCallNode call1, DataFlow::MethodCallNode call2, Class cls |
     meth.getName() = name and
     meth.getScope() = cls and
-    not call1 = call2 and
+    call1.asExpr() != call2.asExpr() and
     calledMulti = getASuperCallTarget(cls, meth, call1) and
     calledMulti = getASuperCallTarget(cls, meth, call2) and
     nonTrivial(calledMulti)
diff --git a/python/ql/src/Classes/CallsToInitDel/SuperclassDelCalledMultipleTimes.ql b/python/ql/src/Classes/CallsToInitDel/SuperclassDelCalledMultipleTimes.ql
@@ -15,7 +15,7 @@ import python
 import MethodCallOrder
 
 predicate multipleCallsToSuperclassDel(Function meth, Function calledMulti) {
-  multipleCallsToSuperclassMethod(meth, calledMulti, "__sel__")
+  multipleCallsToSuperclassMethod(meth, calledMulti, "__del__")
 }
 
 from Function meth, Function calledMulti

Original file line number	Diff line number	Diff line change
`@@ -15,7 +15,7 @@ import python`
`15`	`15`	`import MethodCallOrder`
`16`	`16`
`17`	`17`	`predicate multipleCallsToSuperclassDel(Function meth, Function calledMulti) {`
`18`		`- multipleCallsToSuperclassMethod(meth, calledMulti, "__sel__")`
	`18`	`+ multipleCallsToSuperclassMethod(meth, calledMulti, "__del__")`
`19`	`19`	`}`
`20`	`20`
`21`	`21`	`from Function meth, Function calledMulti`