Update javascript/ql/src/experimental/Security/CWE-090/LdapInjectionCustomizations.qll

dellalibera · erik-krogh · web-flow · commit 785f335ab8a9 · 2020-09-02T15:22:33.000+02:00
Co-authored-by: Erik Krogh Kristensen &lt;erik-krogh@github.com&gt;
diff --git a/javascript/ql/src/experimental/Security/CWE-090/LdapInjectionCustomizations.qll b/javascript/ql/src/experimental/Security/CWE-090/LdapInjectionCustomizations.qll
@@ -50,8 +50,11 @@ module LdapInjection {
   /**
    * An LDAP DN argument for an API call that executes an operation against the LDAP server.
    */
-  class LdapjsDNArgumentAsSink extends Sink, LdapjsDNArgument {
-    override DataFlow::InvokeNode getQueryCallSink() {
+  class LdapjsDNArgumentAsSink extends Sink {
+    LdapjsDNArgumentAsSink() {
+      this instanceof LdapjsDNArgument
+    }
+    override DataFlow::InvokeNode getQueryCall() {
       result = this.(LdapjsDNArgument).getQueryCall()
     }
   }

Original file line number	Diff line number	Diff line change
`@@ -50,8 +50,11 @@ module LdapInjection {`
`50`	`50`	`/**`
`51`	`51`	`* An LDAP DN argument for an API call that executes an operation against the LDAP server.`
`52`	`52`	`*/`
`53`		`- class LdapjsDNArgumentAsSink extends Sink, LdapjsDNArgument {`
`54`		`- override DataFlow::InvokeNode getQueryCallSink() {`
	`53`	`+ class LdapjsDNArgumentAsSink extends Sink {`
	`54`	`+ LdapjsDNArgumentAsSink() {`
	`55`	`+ this instanceof LdapjsDNArgument`
	`56`	`+ }`
	`57`	`+ override DataFlow::InvokeNode getQueryCall() {`
`55`	`58`	`result = this.(LdapjsDNArgument).getQueryCall()`
`56`	`59`	`}`
`57`	`60`	`}`