JS: Fix FPs from ParameterFieldAsPropWrite.getPropertyNameExpr

asgerf · asgerf · commit 790d2ba0fce4 · 2020-10-05T09:55:22.000+01:00
diff --git a/javascript/ql/src/semmle/javascript/dataflow/DataFlow.qll b/javascript/ql/src/semmle/javascript/dataflow/DataFlow.qll
@@ -709,7 +709,9 @@ module DataFlow {
       result = thisNode(prop.getDeclaringClass().getConstructor().getBody())
     }
 
-    override Expr getPropertyNameExpr() { result = prop.getNameExpr() }
+    override Expr getPropertyNameExpr() {
+      none() // The parameter value is not the name of the field
+    }
 
     override string getPropertyName() { result = prop.getName() }
 

Original file line number	Diff line number	Diff line change
`@@ -709,7 +709,9 @@ module DataFlow {`
`709`	`709`	`result = thisNode(prop.getDeclaringClass().getConstructor().getBody())`
`710`	`710`	`}`
`711`	`711`
`712`		`- override Expr getPropertyNameExpr() { result = prop.getNameExpr() }`
	`712`	`+ override Expr getPropertyNameExpr() {`
	`713`	`+ none() // The parameter value is not the name of the field`
	`714`	`+ }`
`713`	`715`
`714`	`716`	`override string getPropertyName() { result = prop.getName() }`
`715`	`717`