JS: Port threat-model test to ConfigSig

Author: asgerf

javascript/ql/test/library-tests/threat-models/sources/TestSources.expected

@@ -1,2 +1,3 @@
+legacyDataFlowDifference
 testFailures
 failures

javascript/ql/test/library-tests/threat-models/sources/TestSources.ql

@@ -1,25 +1,33 @@
 import javascript
 import testUtilities.InlineExpectationsTest
 
-class TestSourcesConfiguration extends TaintTracking::Configuration {
-  TestSourcesConfiguration() { this = "TestSources" }
+module TestConfig implements DataFlow::ConfigSig {
+  predicate isSource(DataFlow::Node source) { source instanceof ThreatModelSource }
 
-  override predicate isSource(DataFlow::Node source) { source instanceof ThreatModelSource }
-
-  override predicate isSink(DataFlow::Node sink) {
+  predicate isSink(DataFlow::Node sink) {
     exists(CallExpr call |
       call.getAnArgument() = sink.asExpr() and
       call.getCalleeName() = "SINK"
     )
   }
 }
 
+module TestFlow = TaintTracking::Global<TestConfig>;
+
+deprecated class LegacyConfig extends TaintTracking::Configuration {
+  LegacyConfig() { this = "TestSources" }
+
+  override predicate isSource(DataFlow::Node source) { TestConfig::isSource(source) }
+
+  override predicate isSink(DataFlow::Node sink) { TestConfig::isSink(sink) }
+}
+
 private module InlineTestSources implements TestSig {
   string getARelevantTag() { result in ["hasFlow", "threat-source"] }
 
   predicate hasActualResult(Location location, string element, string tag, string value) {
     exists(DataFlow::Node sink |
-      any(TestSourcesConfiguration c).hasFlow(_, sink) and
+      TestFlow::flowTo(sink) and
       value = "" and
       location = sink.getLocation() and
       tag = "hasFlow" and
@@ -36,3 +44,4 @@ private module InlineTestSources implements TestSig {
 }
 
 import MakeTest<InlineTestSources>
+deprecated import testUtilities.LegacyDataFlowDiff::DataFlowDiff<TestFlow, LegacyConfig>