File tree Expand file tree Collapse file tree 2 files changed +5
-2
lines changed
Expand file tree Collapse file tree 2 files changed +5
-2
lines changed Original file line number Diff line number Diff line change @@ -74,7 +74,7 @@ class AndroidApplicationXmlElement extends XmlElement {
7474 predicate requiresPermissions ( ) { this .getAnAttribute ( ) .( AndroidPermissionXmlAttribute ) .isFull ( ) }
7575
7676 /**
77- * Holds if this application element enables the `android:allowBackup` attribute.
77+ * Holds if this application element does not disable the `android:allowBackup` attribute.
7878 *
7979 * https://developer.android.com/guide/topics/data/autobackup
8080 */
Original file line number Diff line number Diff line change 11/**
22 * @name Android allowBackup attribute enabled
3- * @description
3+ * @description Android manifests which do not disable the `android:allowBackup` attribute allow backups, which can store sensitive information.
44 * @kind problem
55 * @problem.severity recommendation
66 * @security-severity 7.5
@@ -17,8 +17,11 @@ from AndroidApplicationXmlElement androidAppElem
1717where
1818 not androidAppElem .getFile ( ) .( AndroidManifestXmlFile ) .isInBuildDirectory ( ) and
1919 (
20+ // explicitly sets android:allowBackup=true
2021 androidAppElem .allowsBackupExplicitly ( )
2122 or
23+ // Manifest providing the main intent for an application, and does not explicitly
24+ // disallow the allowBackup attribute
2225 androidAppElem .providesMainIntent ( ) and
2326 androidAppElem .allowsBackup ( )
2427 )
You can’t perform that action at this time.
0 commit comments