Bazel: add a test wrapper around installation scripts#18276
Merged
Conversation
This hack is meant to be an optimization when using install for tests, where the install step is skipped if nothing changed. If the installation directory is somehow messed up, `bazel run` can be used to force install. This is added as a `<name>-installer-as-test` target, which we can now use in our internal pytest integration to skip the installation step if nothing changed on the CLI + language packs side.
Contributor
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request.
Files not reviewed (1)
- misc/bazel/pkg.bzl: Language not supported
Tip: Copilot only keeps its highest confidence comments to reduce noise and keep you focused. Learn more
criemen
approved these changes
Dec 16, 2024
Collaborator
criemen
left a comment
criemen
left a comment
There was a problem hiding this comment.
I'm not super happy about the UX of this, but this should reduce the pytest snappiness of the inner development loop of integration tests by quite a bit.
We can for sure have this build target exist, and then discuss the UX of actually using the test target on the internal PR for switching pytest over to use it.
| ], | ||
| data = data, | ||
| args = args, | ||
| size = "small", |
Collaborator
There was a problem hiding this comment.
the timeout only covers the install part, right? Which under all circumstances ought to finish in 60 seconds, so this is appropriate.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This hack is meant to be an optimization when using install for tests, where the install step is skipped if nothing changed. If the installation directory is somehow messed up,
bazel runcan be used to force install.This is added as a
<name>-installer-as-testtarget, which we can now use in our internal pytest integration to skip the installation step if nothing changed on the CLI + language packs side.