Conversation
owen-mc
force-pushed
the
go/1.24
branch
3 times, most recently
from
9155891 to
36d073f
Compare
owen-mc
added
the
depends on internal PR
owen-mc
force-pushed
the
go/1.24
branch
4 times, most recently
from
27c555d to
a444a6a
Compare
owen-mc
force-pushed
the
go/1.24
branch
2 times, most recently
from
bf7c52c to
afe4554
Compare
go/extractor/extractor.go
Outdated
| // `typeNameObj` can only be an alias in versions of Go | ||
| // before 1.24. |
There was a problem hiding this comment.
Should this be above the condition? It might also be useful to include what the implications of this are
There was a problem hiding this comment.
I wasn't quite sure where it should go. I can move it a line higher if you think that's clearer. I'm also happy to rephrase it, but I wasn't sure how to put it clearly. Suggestions welcome. Basically, before 1.24 both defined types and named types will satisfy tp, ok := typeNameObj.Type().(*types.Named); ok, and we want to exclude the alias types from going into this branch of the conditional (though I'm not sure if anything bad would happen - I'm just preserving the old behaviour). From 1.24 onwards, alias types will instead satisfy tp, ok := typeNameObj.Type().(*types.Alias); ok, and will be dealt with by the second conditional below this.
There was a problem hiding this comment.
I have moved it and tried to make it clearer.
Allow release candidate versions.
mbg
left a comment
mbg
left a comment
There was a problem hiding this comment.
Looks good. CI failure is expected and should be resolved once the internal PR is merged.
2 participants
No description provided.