Rust: Implement database quality telemetry query#18697
Conversation
There was a problem hiding this comment.
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Tip: Copilot only keeps its highest confidence comments to reduce noise and keep you focused. Learn more
| @@ -0,0 +1,46 @@ | |||
| /** | |||
There was a problem hiding this comment.
We already have a rust/ql/src/queries/diagnostics and rust/ql/src/queries/summary directory and this introduces rust/ql/src/queries/telemetry as well. Are the new queries meaningfully different enough to justify a third location or should we condense back down to (any) two of them?
There was a problem hiding this comment.
I simply followed the same structure that we have for Java and C#.
There was a problem hiding this comment.
OK, I'll look into whether I can combine any of these directories after this PR is merged. Don't really want a proliferation of folders unless they're meaningfully different.
| MacroCallTargetStatsReport::numberOfOk(key, value) or | ||
| MacroCallTargetStatsReport::numberOfNotOk(key, value) or | ||
| MacroCallTargetStatsReport::percentageOfOk(key, value) | ||
| ) and |
There was a problem hiding this comment.
There's quite a bit of overlap with rust/summary/summary-statistics (files and lines of code extracted), the focus is a little different here but something to be aware of.
| /* -Infinity */ | ||
| value != -1.0 / 0.0 and | ||
| /* NaN */ | ||
| value != 0.0 / 0.0 |
There was a problem hiding this comment.
This is hurting my maths brain, but it does seem to be the way float works. :(
|
DCA LGTM, I can see the new "Missing call targets, per source" |
Co-authored-by: Geoffrey White <40627776+geoffw0@users.noreply.github.com>
3 participants
For now, this will yield DCA numbers on missing call targets, but should also eventually yield telemetry data.