Use default query selectors for Actions suites#18705
Merged
Conversation
added 5 commits
February 6, 2025 11:30
These will wind up in `security-extended`, when previously they were not in any of the standard suites.
This ensures that it will remain in the default suite.
This ensures that it will remain in the default suite.
This ensures that it will be in `security-extended`, but not the default suite.
…-security-extended`
Contributor
There was a problem hiding this comment.
Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.
Tip: Copilot only keeps its highest confidence comments to reduce noise and keep you focused. Learn more
dbartol
changed the title
adityasharad
reviewed
Feb 6, 2025
Collaborator
adityasharad
left a comment
adityasharad
left a comment
There was a problem hiding this comment.
Looks reasonable, just some questions on change note.
| @@ -0,0 +1,17 @@ | |||
| --- | |||
| category: queryMetadata | |||
Collaborator
There was a problem hiding this comment.
Can we indicate somehow this is breaking and that alerts from the moved queries will close for existing users?
Author
There was a problem hiding this comment.
I've changed the category to breaking and enhanced the description.
adityasharad
approved these changes
Feb 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR switches the two primary Actions suites to use the same query selectors as all of the other languages. I've adjusted the severity and/or priority of several queries to make sure that they wind up in the right suite. The net changes in suite placement are:
Removed from both suites
These queries are not security-related.
if-expression-always-true/criticalif-expression-always-true/highunnecessary-use-of-advanced-configDemoted to
security-extendedunpinned-tagAdded to
security-extended(previously not in either suite)Most of these are just lower-precision versions of queries from the default suite.
unversioned-immutable-actionenvpath-injection/mediumenvvar-injection/mediumcode-injection/mediumartifact-poisoning/mediumuntrusted-checkout/medium