JS: Extractor handle error instead of exiting.

[Napalys]

Fixes extractor error discovered in #18899 (comment)

[asgerf]

In TypeExprKind.getTypeExprKind could you try adding a case for ParenthesizedExpression (similar to ParenthesizedTypeExpr):

@Override
public Integer visit(ParenthesizedExpression nd, Void c) {
  return parenthesizedTypeExpr;
}

[Copilot]

Pull Request Overview

This PR updates the extractor to handle errors gracefully by introducing validity checks in type expression conversions. Key changes include:

• Adding test files with invalid extends to trigger extractor error handling.
• Introducing a default method isValidExpression in ITypeExpression.
• Implementing an override of isValidExpression in MemberExpression.
• Modifying TypeScriptASTConverter to use isValidExpression in type conversion.

Reviewed Changes

Copilot reviewed 5 out of 7 changed files in this pull request and generated no comments.

File	Description
javascript/extractor/tests/ts/input/invalidExtends.ts	Adds test cases with invalid "extends" constructs for extractor error handling
javascript/extractor/src/com/semmle/ts/ast/ITypeExpression.java	Adds default validity check method in the ITypeExpression interface
javascript/extractor/src/com/semmle/js/ast/MemberExpression.java	Adds an override for isValidExpression to check allowed object types
javascript/extractor/src/com/semmle/ts/extractor/TypeScriptASTConverter.java	Updates the asType method to apply the validity check from ITypeExpression

Files not reviewed (2)

• javascript/ql/test/library-tests/TypeScript/Types/printAst.expected: Language not supported
• javascript/ql/test/library-tests/TypeScript/Types/tests.expected: Language not supported

Tip: Copilot only keeps its highest confidence comments to reduce noise and keep you focused. Learn more

[asgerf]

👍