Ruby: Make module graph queries avoid relying on evalaution order.

[alexet]

Graphs use the internal id if semmle.order is not good enough. However the internal id of a newtype depends on evaluation order (and in this case whether TResolved or TUnresolved is evaluated first). It seems the current evaluator is very consistent but RTJO changes it. In theory though the current evaluator could get the wrong result as multiple threads can change scheduling order.

I am looking into making the graph code use the label as an intermediate order. However we end up still needing us to make this test deterministic as the change would break this test.

This just adds the toString as an order when the location is not defined, I have put these first in the order as that matches the existing results better (if semmle.order is not defined then it is treated 0).

I have duplicated this code as it is already duplicated but I am happy to put this in a qll instead as this code has grown in size.

[Copilot]

Copilot wasn't able to review any files in this pull request.

Files not reviewed (4)

• ruby/ql/test/library-tests/modules/ancestors.expected: Language not supported
• ruby/ql/test/library-tests/modules/ancestors.ql: Language not supported
• ruby/ql/test/library-tests/modules/superclasses.expected: Language not supported
• ruby/ql/test/library-tests/modules/superclasses.ql: Language not supported

[adityasharad]

I defer to others on how to organise the code, but changes look reasonable.