Ssa: Deprecate the public DefinitionExt and PhiReadNode#19160
Merged
aschackmull merged 3 commits intogithub:mainfrom Apr 4, 2025
Merged
Ssa: Deprecate the public DefinitionExt and PhiReadNode#19160aschackmull merged 3 commits intogithub:mainfrom
aschackmull merged 3 commits intogithub:mainfrom
Conversation
github-actions
bot
added
Java
Rust
aschackmull
force-pushed
the
ssa/deprecate-definitionext
branch
from
bc49797 to
cff6299
Compare
github-actions
bot
removed
Java
Rust
aschackmull
force-pushed
the
ssa/deprecate-definitionext
branch
from
cff6299 to
34554fd
Compare
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR deprecates public references to the DefinitionExt and PhiReadNode classes in the SSA library, making them internal-only while still retaining their functionality in the background.
- Added a change note indicating the deprecation of public references to DefinitionExt and PhiReadNode.
Files not reviewed (1)
- shared/ssa/codeql/ssa/Ssa.qll: Language not supported
Tip: If you use Visual Studio Code, you can request a review from Copilot before you push from the "Source Control" tab. Learn more
hvitved
reviewed
Apr 3, 2025
Contributor
hvitved
left a comment
hvitved
left a comment
There was a problem hiding this comment.
One question, otherwise LGTM.
| not uncertainWriteDefinitionInput(_, def) | ||
| } | ||
|
|
||
| /** Holds if a read is not dominated by a definition. */ |
Contributor
Author
There was a problem hiding this comment.
Ah, I was too quick there. I removed it because it referenced deprecated predicates, but I should just have updated those references. Fix incoming.
hvitved
approved these changes
Apr 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR deprecates all public predicates and classes in the SSA library that somehow reference phi-read nodes or
DefinitionExt. TheDefinitionExtandPhiReadNodeclasses are still used internally in the SSA library, but they're now completely hidden.