Rust: upgrade rust-analyzer to 0.0.273#19233
Merged
Conversation
aibaars
reviewed
Apr 11, 2025
| # patch for build script bug preventing bazel build | ||
| # see https://github.com/rust-lang/rustc_apfloat/pull/17 | ||
| rustc_apfloat = { git = "https://github.com/redsun82/rustc_apfloat.git", rev = "096d585100636bc2e9f09d7eefec38c5b334d47b" } | ||
| rustc_apfloat = { git = "https://github.com/redsun82/rustc_apfloat.git", rev = "32968f16ef1b082243f9bf43a3fbd65c381b3e27" } |
Contributor
There was a problem hiding this comment.
It looks like your PR was merged 4 days ago. rust-lang/rustc_apfloat#17 I suppose we still need this patch for a little while, but hopefully we can drop it once a new version of rustc_apfloat is published
Contributor
Author
There was a problem hiding this comment.
yes, I don't know how long it will be till my patch gets released
Contributor
Author
|
DCA shows some minor changes, but all seems acceptable to me. |
aibaars
approved these changes
Apr 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The new
is_unsafepredicate added to struct fields is an experimental addition, more details in https://rust-lang.github.io/rust-project-goals/2025h1/unsafe-fields.html.Commit by commit review is encouraged.
This includes #19291 which should therefore be merged before this.