QL4QL: Restrict ql/qlref-inline-expectations to (path-)problem queries#19272
Merged
hvitved merged 2 commits intogithub:mainfrom Apr 23, 2025
Merged
QL4QL: Restrict ql/qlref-inline-expectations to (path-)problem queries#19272hvitved merged 2 commits intogithub:mainfrom
ql/qlref-inline-expectations to (path-)problem queries#19272hvitved merged 2 commits intogithub:mainfrom
Conversation
hvitved
force-pushed
the
ql4ql/qlref-inline-exp-kind-restrict
branch
from
d6f09cf to
a578f44
Compare
Contributor
There was a problem hiding this comment.
Copilot reviewed 1 out of 9 changed files in this pull request and generated no comments.
Files not reviewed (8)
- ql/ql/src/codeql/files/FileSystem.qll: Language not supported
- ql/ql/src/codeql_ql/ast/Yaml.qll: Language not supported
- ql/ql/src/queries/style/QlRefInlineExpectations.ql: Language not supported
- ql/ql/test/queries/style/QlRefInlineExpectations/ProblemQuery.ql: Language not supported
- ql/ql/test/queries/style/QlRefInlineExpectations/QlRefInlineExpectations.expected: Language not supported
- ql/ql/test/queries/style/QlRefInlineExpectations/Test1.qlref: Language not supported
- ql/ql/test/queries/style/QlRefInlineExpectations/Test2.qlref: Language not supported
- ql/ql/test/queries/style/QlRefInlineExpectations/Test3.qlref: Language not supported
geoffw0
reviewed
Apr 11, 2025
Contributor
geoffw0
left a comment
geoffw0
left a comment
There was a problem hiding this comment.
I ran into false positives of this nature a couple of times recently. It's a good condition to add to the query.
| } | ||
| } | ||
|
|
||
| private predicate shouldAppend(QlRefDocument qlref, Folder f, string relativePath) { |
Contributor
There was a problem hiding this comment.
It would make the code a lot more readable if this predicate had a QLDoc comment.
asgerf
approved these changes
Apr 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Interesting that I had another use case for the
Folder::Appendmodule, just a few days after I introduced it.