Closed
Conversation
Contributor
There was a problem hiding this comment.
Copilot reviewed 109 out of 129 changed files in this pull request and generated no comments.
Files not reviewed (20)
- MODULE.bazel: Language not supported
- misc/bazel/3rdparty/tree_sitter_extractors_deps/BUILD.android_system_properties-0.1.5.bazel: Language not supported
- misc/bazel/3rdparty/tree_sitter_extractors_deps/BUILD.anstyle-wincon-3.0.7.bazel: Language not supported
- misc/bazel/3rdparty/tree_sitter_extractors_deps/BUILD.anyhow-1.0.98.bazel: Language not supported
- misc/bazel/3rdparty/tree_sitter_extractors_deps/BUILD.argfile-0.2.1.bazel: Language not supported
- misc/bazel/3rdparty/tree_sitter_extractors_deps/BUILD.atomic-0.6.0.bazel: Language not supported
- misc/bazel/3rdparty/tree_sitter_extractors_deps/BUILD.bazel: Language not supported
- misc/bazel/3rdparty/tree_sitter_extractors_deps/BUILD.borsh-1.5.7.bazel: Language not supported
- misc/bazel/3rdparty/tree_sitter_extractors_deps/BUILD.bstr-1.12.0.bazel: Language not supported
- misc/bazel/3rdparty/tree_sitter_extractors_deps/BUILD.bumpalo-3.17.0.bazel: Language not supported
- misc/bazel/3rdparty/tree_sitter_extractors_deps/BUILD.bytemuck-1.22.0.bazel: Language not supported
- misc/bazel/3rdparty/tree_sitter_extractors_deps/BUILD.byteorder-1.5.0.bazel: Language not supported
- misc/bazel/3rdparty/tree_sitter_extractors_deps/BUILD.cc-1.2.19.bazel: Language not supported
- misc/bazel/3rdparty/tree_sitter_extractors_deps/BUILD.chrono-0.4.40.bazel: Language not supported
- misc/bazel/3rdparty/tree_sitter_extractors_deps/BUILD.clap-4.5.36.bazel: Language not supported
- misc/bazel/3rdparty/tree_sitter_extractors_deps/BUILD.clap_builder-4.5.36.bazel: Language not supported
- misc/bazel/3rdparty/tree_sitter_extractors_deps/BUILD.crossbeam-channel-0.5.15.bazel: Language not supported
- misc/bazel/3rdparty/tree_sitter_extractors_deps/BUILD.darling-0.20.11.bazel: Language not supported
- misc/bazel/3rdparty/tree_sitter_extractors_deps/BUILD.darling_core-0.20.11.bazel: Language not supported
- misc/bazel/3rdparty/tree_sitter_extractors_deps/BUILD.darling_macro-0.20.11.bazel: Language not supported
aibaars
previously approved these changes
Apr 15, 2025
aibaars
force-pushed
the
redsun82/cargo-upgrade-2
branch
2 times, most recently
from
a85de02 to
5b76400
Compare
geoffw0
reviewed
May 19, 2025
| ) | ||
| ) | ||
| or | ||
| // callable -> callable attribute macro expansion |
Contributor
There was a problem hiding this comment.
Is this comment intended to be here?
Contributor
Author
There was a problem hiding this comment.
oh, whoops, this was in a previous version I had, let me fix that, thanks!
redsun82
force-pushed
the
redsun82/cargo-upgrade-2
branch
from
a615ba1 to
5ec72b2
Compare
geoffw0
reviewed
May 22, 2025
Contributor
Author
sorry, I was sure I had done it |
Contributor
|
Extractor changes still need reviewing. I can do it if you're desperate / fairly confident / willing to answer basic questions. |
added 5 commits
May 23, 2025 12:00
Contributor
Author
At this point I would have you review the selected out commits in #19572 |
redsun82
force-pushed
the
redsun82/cargo-upgrade-2
branch
from
a1b66ff to
9a0f5af
Compare
Contributor
Author
|
obsoleted by #19524 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An outline of included work:
crate_graph.rsto the underlying unstable API changesrust-analyzerrequires that.emit_detachedinto a more genericpost_emit, and adding a correspondingpre_emit: this allows to do the above in terms of thepre_emit/post_emitpair forItem