Shared: Re-factor summary, source and sink model generators into separate modules.#19382
Merged
michaelnebel merged 7 commits intogithub:mainfrom May 2, 2025
Merged
Conversation
github-actions
bot
added
C#
C++
documentation
Java
Rust
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| private import semmle.code.cpp.dataflow.internal.FlowSummaryImpl as FlowSummaryImpl | ||
| private import semmle.code.cpp.ir.dataflow.internal.TaintTrackingImplSpecific | ||
| private import semmle.code.cpp.dataflow.new.TaintTracking | ||
| private import semmle.code.cpp.dataflow.new.TaintTracking as Tt |
Check warning
Code scanning / CodeQL
Names only differing by case Warning
| private import semmle.code.cpp.ir.dataflow.internal.TaintTrackingImplSpecific | ||
| private import semmle.code.cpp.dataflow.new.TaintTracking | ||
| private import semmle.code.cpp.dataflow.new.TaintTracking as Tt | ||
| private import semmle.code.cpp.dataflow.new.DataFlow as Df |
Check warning
Code scanning / CodeQL
Names only differing by case Warning
michaelnebel
force-pushed
the
shared/modelgenrefactor
branch
2 times, most recently
from
4fea2b0 to
fbe0394
Compare
michaelnebel
added
the
no-change-note-required
…rate param modules.
michaelnebel
force-pushed
the
shared/modelgenrefactor
branch
from
fbe0394 to
c9d01bc
Compare
MathiasVP
reviewed
Apr 29, 2025
Contributor
MathiasVP
left a comment
MathiasVP
left a comment
There was a problem hiding this comment.
The C/C++ parts LGTM 👍
paldepind
approved these changes
Apr 30, 2025
Contributor
paldepind
left a comment
paldepind
left a comment
There was a problem hiding this comment.
The Rust changes LGTM :)
Contributor
Author
|
DCA for Java looks fine (workflow errors for C#). I think that is acceptable for confidence in the changes. |
Contributor
Author
|
The DCA retry for C# appears to have succeeded (modulo some other workflow failure that I don't understand). It appears that the re-factor doesn't impact performance. |
Contributor
Author
|
Merging now before we get more merge conflicts. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this PR we re-write the model generator into separate (nested) parameterized modules. Prior to this change it was only possible to create a model generator that could create summaries, neutrals, source and sinks. If only summary/neutral models are of interest, one still needed to provide all the source and sink model generation related parameters (as these were included in the input signature for model generator). With this change the model generator is turned into a series of nested parameterized modules.
That is, to create a model generator one now needs to
Furthermore, in this PR we sprinkle sensible predicate defaults for some of the model generator input predicates.