Add code quality suite selector and use that in the code quality suites#19413
Merged
tamasvajk merged 8 commits intogithub:mainfrom May 2, 2025
Merged
Add code quality suite selector and use that in the code quality suites#19413tamasvajk merged 8 commits intogithub:mainfrom
tamasvajk merged 8 commits intogithub:mainfrom
Conversation
github-actions
bot
added
JS
C++
Python
Go
Ruby
Rust
tamasvajk
commented
Apr 29, 2025
| @@ -1,3 +1,2 @@ | |||
| ql/ruby/ql/src/queries/performance/DatabaseQueryInLoop.ql | |||
| ql/ruby/ql/src/queries/variables/DeadStoreOfLocal.ql | |||
Contributor
Author
There was a problem hiding this comment.
This query has precision medium.
Contributor
Author
There was a problem hiding this comment.
@github/codeql-ruby could you check if you're okay with this change?
tamasvajk
commented
Apr 29, 2025
python/ql/integration-tests/query-suite/python-code-quality.qls.expected
Show resolved
Hide resolved
tamasvajk
commented
Apr 29, 2025
java/ql/integration-tests/java/query-suite/java-code-quality.qls.expected
Show resolved
Hide resolved
geoffw0
approved these changes
Apr 30, 2025
Contributor
geoffw0
left a comment
geoffw0
left a comment
There was a problem hiding this comment.
Looks good from the point-of-view of Rust and Swift.
| * @problem.severity warning | ||
| * @id rb/useless-assignment-to-local | ||
| * @tags maintainability | ||
| * quality |
Contributor
There was a problem hiding this comment.
What queries are supposed to get the quality tag? Should we be adding it to existing and new queries (e.g. cpp/unused-static-function, rust/unused-variable)?
Contributor
Author
There was a problem hiding this comment.
I think eventually all "quality" queries should have the quality tag.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is changing the code-quality query suites to not list individual query IDs, but instead use a shared selector.
Note that the modification results in changes in the following suites: Java, Python, Ruby.