ruby: adjust precision of rb/useless-assignment-to-local#19476
Merged
yoff merged 1 commit intogithub:mainfrom May 13, 2025
Merged
ruby: adjust precision of rb/useless-assignment-to-local#19476yoff merged 1 commit intogithub:mainfrom
rb/useless-assignment-to-local#19476yoff merged 1 commit intogithub:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR raises the precision level of the Ruby rb/useless-assignment-to-local query from medium to high and documents the change.
- Updated the
@precisiontag in the query metadata. - Added a change-note entry recording the precision adjustment.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| ruby/ql/src/queries/variables/DeadStoreOfLocal.ql | Changed @precision from medium to high |
| ruby/ql/src/change-notes/2025-05-12-rb-useless-assignment-to-local-precision-high.md | Added note on precision update |
from `medium` to `high`
yoff
force-pushed
the
ruby/DeadStoreOfLocal-precision-high
branch
from
3a88562 to
a501678
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
from
mediumtohigh. It was initially set tomediumdue to the number of alerts observed on the Java top 100 via MRVA. However, after triaging a large number of these, it does indeed seem that they are almost all true positives.