Quantum: Support for BouncyCastle signature algorithms and block cipher modes#19568
Closed
fegge wants to merge 32 commits intogithub:mainfrom
Closed
Quantum: Support for BouncyCastle signature algorithms and block cipher modes#19568fegge wants to merge 32 commits intogithub:mainfrom
fegge wants to merge 32 commits intogithub:mainfrom
Conversation
fegge
force-pushed
the
fegge/bouncycastle
branch
2 times, most recently
from
8d2ec44 to
5884c71
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
There was a problem hiding this comment.
CodeQL found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.
nicolaswill
requested changes
Jun 2, 2025
Contributor
nicolaswill
left a comment
nicolaswill
left a comment
There was a problem hiding this comment.
The BouncyCastle stubs need a copy of the license file:
https://github.com/bcgit/bc-java/blob/main/LICENSE.md
Aside from that, please resolve the QL for QL Code Scanning alerts (with the exception of class naming to match camelCase or PascalCase for acronyms... we can do that later).
I have not yet reviewed all of the modeling.
aibaars
reviewed
Jun 3, 2025
aibaars
reviewed
Jun 5, 2025
java/ql/lib/experimental/quantum/BouncyCastle/OperationInstances.qll
Outdated
Show resolved
Hide resolved
java/ql/lib/experimental/quantum/BouncyCastle/OperationInstances.qll
Outdated
Show resolved
Hide resolved
java/ql/lib/experimental/quantum/BouncyCastle/OperationInstances.qll
Outdated
Show resolved
Hide resolved
java/ql/lib/experimental/quantum/BouncyCastle/OperationInstances.qll
Outdated
Show resolved
Hide resolved
This commit adds the `KeyGenerationOperationInstance` and `KeyGenerationAlgorithmInstance` types to the BouncyCastle model. It also adds data flow support from key pairs to the corresponding public and private components.
This commit also adds associated elliptic curves to the key generation and key nodes.
This commit adds support for ECDSA. This includes tracking the instantiated curve parameters using data flow. It also adds SignatureArtifactInstance and SignatureOperationInstance types to the shared model.
This commit adds EllipticCurveConsumingAlgorithmInstance to the shared model, allowing us to model and graph elliptic curve algorithms.
Co-authored-by: Arthur Baars <aibaars@github.com>
This commit also reorganizes the Bouncy Castle test cases into separate sub-directories for signature and cipher modes.
fegge
force-pushed
the
fegge/bouncycastle
branch
from
6c68be5 to
7969bdf
Compare
fegge
changed the title
|
|
||
| override Crypto::KeyOperationSubtype getKeyOperationSubtype() { | ||
| // The key operation sub-type is determined by the `encrypting` argument to `init()`. | ||
| exists(this.getInitCall()) and |
Check warning
Code scanning / CodeQL
Superfluous 'exists' conjunct. Warning
- Signature operations are now handled by a single algorithm instance - All key generation operations except generic EC key generation operations are now handled by a single algorithm instance - Ed25519 and Ed448 key generation have the algorithm set to Ed25519 and Ed448 respectively - For generic EC key generation operations the algorithm is given by the corresponding curve (since these could be used for either ECDSA or ECDH)
Contributor
|
Closing, moved to #20575. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To be reviewed by @nicolaswill.