CI: remove deprecated windows-2019 usage#19642
Merged
Conversation
redsun82
force-pushed
the
redsun82/rm-windows-2019
branch
from
11e8bad to
b1afa66
Compare
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR removes deprecated Windows 2019 runners and updates all OS versions in the build-ripunzip workflow.
- Replace
windows-2019withwindows-latestin the C# QL test workflow - Update
build-ripunziprunners from specific older versions to newer releases
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| .github/workflows/csharp-qltest.yml | Switched matrix OS from windows-2019 to windows-latest |
| .github/workflows/build-ripunzip.yml | Updated matrix OS entries to ubuntu-24.04, macos-15, windows-2025 |
Comments suppressed due to low confidence (1)
.github/workflows/build-ripunzip.yml:20
- The runner labels
ubuntu-24.04,macos-15, andwindows-2025are not currently supported by GitHub Actions. Please use valid GitHub-hosted runners such asubuntu-latest,macos-latest, or a specific supported version likewindows-2022.
os: [ubuntu-24.04, macos-15, windows-2025]
Contributor
Author
|
Successful run of the ripunzip workflow: https://github.com/github/codeql/actions/runs/15396339049 |
sam-robson
approved these changes
Jun 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The rip-unzip build workflow is using slightly older runners to ensure being runnable on supported platforms, though admittedly I don't know whether that can be an issue on windows.