Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR upgrades ripunzip to version 2.0.2 by switching from direct binary LFS pointers to ZIP archives in Bazel builds and updating BUILD rules accordingly.
- Replaced per-OS binary LFS pointers with ZIP-based LFS pointers.
- Introduced a
native_binaryrule inBUILD.ripunzip.bazeland updated the alias inBUILD.bazel. - Swapped out
lfs_filesforlfs_archiveinMODULE.bazelto consume the new ZIP archives.
Reviewed Changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| misc/ripunzip/ripunzip-windows.exe | Removed LFS pointer lines, leaving an empty file |
| misc/ripunzip/ripunzip-macos | Removed LFS pointer lines, leaving an empty file |
| misc/ripunzip/ripunzip-linux | Removed LFS pointer lines, leaving an empty file |
| misc/ripunzip/ripunzip-macOS.zip | Added LFS pointer for macOS ZIP archive |
| misc/ripunzip/ripunzip-Windows.zip | Added LFS pointer for Windows ZIP archive |
| misc/ripunzip/ripunzip-Linux.zip | Added LFS pointer for Linux ZIP archive |
| misc/ripunzip/BUILD.ripunzip.bazel | Added a native_binary target wrapping the unzipped artifact |
| misc/ripunzip/BUILD.bazel | Updated alias ripunzip to point to new per-OS repos |
| MODULE.bazel | Replaced lfs_files rules with lfs_archive rules |
Comments suppressed due to low confidence (2)
misc/ripunzip/ripunzip-windows.exe:1
- The binary file
ripunzip-windows.exehas been emptied instead of being deleted or replaced, resulting in a zero-byte tracked file. Please remove this file from the repository or restore the correct LFS pointer content.
version https://git-lfs.github.com/spec/v1
misc/ripunzip/BUILD.bazel:4
- The
selectonactualcovers only Linux, Windows, and macOS without a//conditions:defaultfallback. Adding a default case will prevent build failures on other platforms.
actual = select({"@platforms//os:" + os: "@ripunzip-%s//:ripunzip" % os for os in ("linux", "windows", "macos")} ),
Contributor
Author
|
(we are not making the workflow directly update the LFS files to avoid spamming the LFS quota, but that could be rediscussed) |
sam-robson
approved these changes
Jun 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These are the result of this run, and after I understood there was no way for a reviewer to check that, I changed the bazel wrapping to directly use the zip archives from that run. This means that now the SHA256 printed by the GitHub UI in the workflow summary can be directly compared with the SHA256 in the LFS pointers.
In this case:
compares to