Rust: Use QL computed canonical paths in MaD Field tokens#19667
Rust: Use QL computed canonical paths in MaD Field tokens#19667
Field tokens#19667Conversation
Also regenerate all auto-generated models with latest extractor.
geoffw0
left a comment
geoffw0
left a comment
There was a problem hiding this comment.
I'll look into a couple of the test failures...
| - ["repo:https://github.com/hyperium/hyper:hyper", "<crate::client::conn::http1::SendRequest>::send_request", "ReturnValue.Future.Field[core::result::Result::Ok(0)]", "remote", "manual"] | ||
| - ["repo:https://github.com/hyperium/hyper:hyper", "<crate::client::conn::http2::SendRequest>::send_request", "ReturnValue.Future.Field[core::result::Result::Ok(0)]", "remote", "manual"] | ||
| - ["repo:https://github.com/hyperium/hyper:hyper", "<crate::client::conn::http1::SendRequest>::try_send_request", "ReturnValue.Future.Field[core::result::Result::Ok(0)]", "remote", "manual"] | ||
| - ["repo:https://github.com/hyperium/hyper:hyper", "<crate::client::conn::http2::SendRequest>::try_send_request", "ReturnValue.Future.::Result::Ok(0)]", "remote", "manual"] |
There was a problem hiding this comment.
This one looks broken, we've lost Field[core::result
There was a problem hiding this comment.
hmm, shouldn't CI catch this?
There was a problem hiding this comment.
It's fixed now, it was an editing mistake during search&replace. But now I'm wary: shouldn't that have been catched?
There was a problem hiding this comment.
I think perhaps there are some validation checks that we could enable.
There was a problem hiding this comment.
would Private::External::invalidSpecComponent like is used in this query flag that, if we didn't look for a SummarizedCallable?
|
Weird that we get flow through |
|
for now I'm leaving this aside, I will rerun generation on it using DCA after #19674 is in. |
* fix a bug where the order of model generation was determined by the order in the `download.json` file of the experiment rather than the order in the config file * allow configuring `--ram` and `--threads` in the MaD generator scripts * use no `--ram` and `--threads=0` by default in the bulk generator (single generator defaults are left unchanged) * allow to pass `--dca` multiple times, taking DBs from experiments listed last. This allows to run a subset of the sources in a "fixup" experiment and use it to "patch" a previous run without rerunning everything.
| @@ -113,7 +113,7 @@ async fn test_futures_rustls_futures_io() -> io::Result<()> { | |||
| sink(&pinned); // $ hasTaintFlow=url | |||
| let mut cx = Context::from_waker(futures::task::noop_waker_ref()); | |||
| let buffer = pinned.poll_fill_buf(&mut cx); | |||
| sink(&buffer); // $ MISSING: hasTaintFlow=url | |||
| sink(&buffer); // $ hasTaintFlow=url | |||
There was a problem hiding this comment.
I reckon this happens because getCanonicalPath is computed also for library structs/enums?
There was a problem hiding this comment.
I think that's the case, yes 👍
redsun82
force-pushed
the
redsun82/rust-mad
branch
from
1634029 to
836b81d
Compare
|
The failing |
3 participants
Also regenerate all auto-generated models with latest extractor.