Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the crate graph test expectations to match the new cfg_if version and ensures the test’s Cargo.lock is tracked to prevent future transitive dependency drift.
- Bumps
cfg_ifexpected version from 1.0.0 to 1.0.1 in the test output. - Adds a
.gitignorerule to unignore and commit the test’sCargo.lock.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| rust/ql/test/extractor-tests/crate_graph/crates.expected | Updated cfg_if entries to version 1.0.1 in expected output |
| rust/ql/test/extractor-tests/crate_graph/.gitignore | Unignore Cargo.lock to lock test dependencies |
Comments suppressed due to low confidence (1)
rust/ql/test/extractor-tests/crate_graph/.gitignore:1
- The PR description mentions committing Cargo.lock, but I don’t see Cargo.lock added in this diff. Please ensure the test’s Cargo.lock file is actually committed alongside this .gitignore update to lock transitive dependencies.
!/Cargo.lock
hvitved
approved these changes
Jun 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Transitive dependencies can get updated, and this happened to the
cfg_ifcrate that caused this test to fail onmain.By fixing the expected file but also committing the cargo lock file, we should be avoiding this problem in the future.