Rust: Also apply adjustedAccessType in RelevantAccess

[hvitved]

No description provided.

[Copilot]

Pull Request Overview

This PR extends the RelevantAccess machinery to account for an explicit target declaration when computing adjusted access types, replacing direct calls to getInferredType. It also updates the Rust type‐inference tests and main.rs comments to reflect now‐included unwrap calls and associated‐type bindings.

• Broadened relevantAccessConstraint and MkRelevantAccess to carry a Declaration target so that adjustedAccessType can be applied
• Switched from a.getInferredType to adjustedAccessType in getTypeAt and hasTypeConstraint
• Updated test expectations and main.rs to register the previously missing unwrap method and associated‐type occurrences

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File	Description
shared/typeinference/codeql/typeinference/internal/TypeInference.qll	Added target parameter and replaced getInferredType with adjustedAccessType
rust/ql/test/library-tests/type-inference/type-inference.expected	Added expected entries for the unwrap call and associated parameter inference
rust/ql/test/library-tests/type-inference/main.rs	Updated comment to expect method=unwrap

Comments suppressed due to low confidence (1)

shared/typeinference/codeql/typeinference/internal/TypeInference.qll:1024

• The toString method for RelevantAccess doesn’t include the new target field, which could be valuable for debugging; consider appending target.toString() to the output.

string toString() {

[Copilot]

[nitpick] Using an underscore for the target parameter in MkRelevantAccess can obscure which argument is being ignored; consider naming this dummy parameter explicitly (e.g., dummyTarget) to improve readability.

Suggested change

	at = MkRelevantAccess(a, _, apos, prefix) and
	at = MkRelevantAccess(a, dummyTarget, apos, prefix) and

[redsun82]

even though I can't fully understand how this fix works, I can see from the fixed MISSING in that test that it does work 👍