Rust: Use hasImplementation in path resolution#19745
Merged
hvitved merged 1 commit intogithub:mainfrom Jun 13, 2025
Merged
Conversation
c5f3550 to
aeb862b
Compare
aeb862b to
3d18e3e
Compare
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR streamlines path resolution by delegating hasImplementation logic to the base implementation and updates test expectations accordingly.
- Removed custom
hasImplementationoverrides forConstItemNodeandFunctionItemNodein favor ofsuper.hasImplementation(). - Adjusted expected test output to drop duplicate
cloneresolutions fromlifetime.rs.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| rust/ql/lib/codeql/rust/internal/PathResolution.qll | Delegated hasImplementation for Const and Function nodes to the super. |
| rust/ql/test/query-tests/security/CWE-825/CONSISTENCY/PathResolutionConsistency.expected | Removed outdated expected entries for clone from library trait items. |
Comments suppressed due to low confidence (2)
rust/ql/lib/codeql/rust/internal/PathResolution.qll:428
- Consider adding or updating test cases to validate that default trait implementations in library code are still correctly detected by
hasImplementationnow that the custom logic has been removed.
override predicate hasImplementation() { Const.super.hasImplementation() }
rust/ql/lib/codeql/rust/internal/PathResolution.qll:504
- Similarly, add tests for default implementations of trait functions to ensure
hasImplementationstill correctly reports library-sourced trait methods.
override predicate hasImplementation() { Function.super.hasImplementation() }
paldepind
approved these changes
Jun 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.