Rust: Temporarily disable type information to flow into operands#19755
Merged
hvitved merged 1 commit intogithub:mainfrom Jun 13, 2025
Merged
Rust: Temporarily disable type information to flow into operands#19755hvitved merged 1 commit intogithub:mainfrom
hvitved merged 1 commit intogithub:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR temporarily adjusts type inference to prevent implicit borrow types (&, &T) from flowing into operands by:
- Updating expected test outputs to remove borrow-related entries.
- Adding a conditional filter in
TypeInference.qllso only return positions on operations retain their inferred types.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| rust/ql/test/library-tests/type-inference/type-inference.expected | Removed lines expecting & and &T in operand types |
| rust/ql/lib/codeql/rust/internal/TypeInference.qll | Added workaround clause to restrict borrow inference |
Comments suppressed due to low confidence (2)
rust/ql/lib/codeql/rust/internal/TypeInference.qll:769
- [nitpick] Include a
TODOwith a reference to the issue or feature request that will address implicit borrows properly, so this workaround is tracked and removed later.
// temporary workaround until implicit borrows are handled correctly
rust/ql/test/library-tests/type-inference/type-inference.expected:2300
- [nitpick] Consider adding explicit tests for operations in non-return contexts to verify that borrow types are indeed suppressed, ensuring this change doesn’t regress in other scenarios.
-| main.rs:1595:13:1595:14 | v2 | | file://:0:0:0:0 | &T |
| result = CallExprBaseMatching::inferAccessType(a, apos, path0) | ||
| result = CallExprBaseMatching::inferAccessType(a, apos, path0) and | ||
| // temporary workaround until implicit borrows are handled correctly | ||
| if a instanceof Operation then apos.isReturn() else any() |
There was a problem hiding this comment.
[nitpick] This if expression can be simplified to a boolean expression: not(a instanceof Operation) or apos.isReturn(), which is more idiomatic and easier to read.
Suggested change
| if a instanceof Operation then apos.isReturn() else any() | |
| not(a instanceof Operation) or apos.isReturn() |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.