Swift: mass-enable diff-informed queries phase 2 - getASelected{Source,Sink}Location() { none() }

[d10c]

Stacks on top of earlier PR: #19659
Uses patch from: https://github.com/github/codeql-patch/pull/88/commits/ec5681e740c18c792443099fb3e413446616a0ee

Adds getASelected{Source,Sink}Location() { none() } override to queries that select a dataflow source or sink as a location, but not both.

[Copilot]

Pull Request Overview

This PR mass-enables diff-informed incremental mode for Swift security queries by adding a new predicate and stubbing out location selection where only one side is used.

• Added observeDiffInformedIncrementalMode() predicate to all Swift security query config modules.
• Introduced getASelectedSourceLocation(...) { none() } overrides in queries that only select sources.

Reviewed Changes

Copilot reviewed 20 out of 20 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
swift/ql/lib/codeql/swift/security/regex/RegexInjectionQuery.qll	Add observeDiffInformedIncrementalMode
swift/ql/lib/codeql/swift/security/XXEQuery.qll	Add observeDiffInformedIncrementalMode
swift/ql/lib/codeql/swift/security/WeakSensitiveDataHashingQuery.qll	Add observeDiffInformedIncrementalMode
swift/ql/lib/codeql/swift/security/WeakPasswordHashingQuery.qll	Add observeDiffInformedIncrementalMode
swift/ql/lib/codeql/swift/security/UnsafeUnpackQuery.qll	Add observeDiffInformedIncrementalMode and getASelectedSourceLocation
swift/ql/lib/codeql/swift/security/UnsafeJsEvalQuery.qll	Add observeDiffInformedIncrementalMode and getASelectedSourceLocation
swift/ql/lib/codeql/swift/security/UncontrolledFormatStringQuery.qll	Add observeDiffInformedIncrementalMode
swift/ql/lib/codeql/swift/security/StringLengthConflationQuery.qll	Add observeDiffInformedIncrementalMode and getASelectedSourceLocation
swift/ql/lib/codeql/swift/security/StaticInitializationVectorQuery.qll	Add observeDiffInformedIncrementalMode and getASelectedSourceLocation
swift/ql/lib/codeql/swift/security/SqlInjectionQuery.qll	Add observeDiffInformedIncrementalMode
swift/ql/lib/codeql/swift/security/PredicateInjectionQuery.qll	Add observeDiffInformedIncrementalMode
swift/ql/lib/codeql/swift/security/PathInjectionQuery.qll	Add observeDiffInformedIncrementalMode
swift/ql/lib/codeql/swift/security/InsufficientHashIterationsQuery.qll	Add observeDiffInformedIncrementalMode and getASelectedSourceLocation
swift/ql/lib/codeql/swift/security/HardcodedEncryptionKeyQuery.qll	Add observeDiffInformedIncrementalMode
swift/ql/lib/codeql/swift/security/ECBEncryptionQuery.qll	Add observeDiffInformedIncrementalMode
swift/ql/lib/codeql/swift/security/ConstantSaltQuery.qll	Add observeDiffInformedIncrementalMode
swift/ql/lib/codeql/swift/security/ConstantPasswordQuery.qll	Add observeDiffInformedIncrementalMode and getASelectedSourceLocation
swift/ql/lib/codeql/swift/security/CommandInjectionQuery.qll	Add observeDiffInformedIncrementalMode
swift/ql/lib/codeql/swift/security/CleartextTransmissionQuery.qll	Add observeDiffInformedIncrementalMode
swift/ql/lib/codeql/swift/security/CleartextLoggingQuery.qll	Add observeDiffInformedIncrementalMode

Comments suppressed due to low confidence (3)

swift/ql/lib/codeql/swift/security/RegexInjectionQuery.qll:26

• The same observeDiffInformedIncrementalMode stub is duplicated across multiple modules; consider extracting this into a shared trait or base config to reduce repetition and simplify future updates.

predicate observeDiffInformedIncrementalMode() { any() }

swift/ql/lib/codeql/swift/security/regex/RegexInjectionQuery.qll:26

• Add dedicated tests for observeDiffInformedIncrementalMode() to verify that diff-informed incremental flows are correctly activated and that existing queries still produce expected results.

predicate observeDiffInformedIncrementalMode() { any() }

swift/ql/lib/codeql/swift/security/UnsafeUnpackQuery.qll:30

• [nitpick] You've overridden getASelectedSourceLocation but not getASelectedSinkLocation. If this query selects only sources or only sinks, ensure the complementary override is present to avoid unintended default location selection.

Location getASelectedSourceLocation(DataFlow::Node sink) { none() }

[geoffw0]

I'm a bit confused as to why we didn't merge https://github.com/github/codeql/pull/19662/files first, but LGTM.

[d10c]

Thanks! I was leaving the first phase of PRs open in case reviews on the other languages give us something else to change, but actually they are ready to merge (the Go, C++, and Actions PRs are still waiting for a reviewer though).

The merge-base changed after approval.