Rust: do not remove Cargo.lock file when running QL tests#19803
Merged
Rust: do not remove Cargo.lock file when running QL tests#19803
Cargo.lock file when running QL tests#19803Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR stops deleting the Cargo.lock file when preparing QL tests by removing the helper function and its invocation.
- Removed the
remove_file_if_existshelper and its call inprepare(). - Dropped the now-unused
std::path::Pathimport.
Comments suppressed due to low confidence (1)
rust/extractor/src/qltest.rs:64
- Consider adding a test to verify that
Cargo.lockremains intact after runningprepare(), ensuring this change is covered by your test suite.
set_sources(config)?;
paldepind
approved these changes
Jun 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.