Rust: Update DotDotCheck to use getCanonicalPath#19804
Merged
geoffw0 merged 3 commits intogithub:mainfrom Jul 25, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the DotDotCheck class in the Rust security library to use getCanonicalPath instead of getResolvedPath for identifying string contains method calls. This change aims to improve the detection of path traversal sanitization checks by using a more reliable method resolution approach.
- Updates method resolution from
getResolvedPath()togetStaticTarget().getCanonicalPath() - Changes the target string matching to include both
<alloc::string::String>::containsand<core::str>::contains - Modifies the type casting from
ResolvabletoCallExprBaseto support the new resolution method
paldepind
approved these changes
Jul 25, 2025
Contributor
paldepind
left a comment
paldepind
left a comment
There was a problem hiding this comment.
Looks good. Nice that the QL libraries are now good enough that this works.
Contributor
Author
100% |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update
DotDotCheckto usegetCanonicalPathrather thangetResolvedPath.This is not working because (1) we're not finding the static targets of these method calls (presumably because type inference is not quite getting there) and (2) I've been unable to test effectively due to (1), so I'm not even sure the model I've written is correct. I should be able to finish this when type inference is working better in other places, e.g. #19802 .--- merged in latestmain, fixed the paths, and it works now. :)