Add code-quality-extended query suites#19808
Merged
tamasvajk merged 3 commits intogithub:mainfrom Jun 18, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR introduces “extended” code-quality query suites that select all queries tagged with quality, and updates integration tests and expectations accordingly.
- Added
*-code-quality-extended.qlssuite files for each supported language, applying the new selectors and suite-helpers. - Updated each language’s integration-tests
well_known_query_suitesto include the extended suite. - Created or updated
.expectedfiles to list the queries now included in the extended suites and removed them fromnot_included_in_qls.expected.
Reviewed Changes
Copilot reviewed 33 out of 33 changed files in this pull request and generated no comments.
Show a summary per file
| File Pattern | Description |
|---|---|
| /src/codeql-suites/-code-quality-extended.qls | New extended code-quality suite that applies the extended selectors |
| /integration-tests//test.py | Include *-code-quality-extended.qls in the test suite |
| /integration-tests//*-code-quality-extended.qls.expected | List of queries expected in the extended suite (may be empty) |
| /integration-tests//not_included_in_qls.expected | Removed entries for queries now covered by the extended suite |
| misc/suite-helpers/code-quality-extended-selectors.yml | New selector config to pick queries tagged quality |
Comments suppressed due to low confidence (3)
Contributor
|
PR needs to be rebased as #19783 has been merged. |
Napalys
previously approved these changes
Jun 18, 2025
Contributor
Napalys
left a comment
Napalys
left a comment
There was a problem hiding this comment.
JS Looks good to me! I have a feeling we’ll end up with quite a few pull requests that have conflicts. 😆
tamasvajk
force-pushed
the
quality/extended-suite
branch
from
ca09b13 to
fcdc12b
Compare
tamasvajk
force-pushed
the
quality/extended-suite
branch
from
fcdc12b to
94052f1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is adding the code-quality-extended selector and query suite files. The content of the query suites largely match the code-quality suites, because of the not yet added
qualitytags. Rust and Java differences are shown in thenot_included_in_qls.expectedfiles.