Python: Tag quality queries with quality and sub category.

[joefarebrother]

Updated tags for high and very high precision quality queries, using the query metadata guide. It is intended that all of these queries will now be in the quality suite.

A few queries were excluded from this process:

The following queries are specific to python 2; we probably don't need them in the quality suite and could deprecate them at some point:

• py/old-style-octal-literal
• py/truncated-division
• py/inconsistent-equality
• py/property-in-old-style-class
• py/slots-in-old-style-class
• py/super-in-old-style
• py/raises-tuple
• py/unguarded-next-in-generator
• py/use-of-apply
• py/use-of-input
• py/deprecated-slice-method
• py/leaking-list-comprehension

The following queries I was uncertain about, so I have excluded for now:

• py/incomplete-ordering - While this query makes sense for python 3, its current implementation is specific to python 2; since it checks for all four comparison methods being defined, whereas in python 3 only __lt__ and __le__ need to be defined. Thus, as is, this query may have more FPs and a lower precision than its precision: high tag suggests.
• py/import-deprecated-module - This query includes a list of deprecated modules (and suggested replacements) that is very old; so uncertain of the utility of including it in the quality suite without updating it.
• py/unnecessary-delete - I am uncertain about the precision/FP rate of this query, despite its precision: high tag - since it is relatively common to use del to break reference cycles, which this query doesn't appear to account for.
• py/cyclic-import and py/unsafe-cyclic-import - These queries were discussed at some point in a team meeting as queries that we are uncertain about maintaining (in the context of modernizing quality queries), due to its complexity and difficulty to distinguish cases in which the pattern is intentional and done carefully and correctly, from true positives.

[Copilot]

Pull Request Overview

Adds the quality tag (with top-level categories and subcategories) to existing Python queries and updates the Python code-quality suite.

• Standardize metadata: add quality tag and assign appropriate sub-category tags across many Python QL queries
• Document change: add a change-note entry for the new quality-tag convention
• Update tests: expand the Python code-quality suite’s expected query list

Reviewed Changes

Copilot reviewed 94 out of 94 changed files in this pull request and generated no comments.

File	Description
python/ql/src/change-notes/2025-06-18-quality-query-metadata.md	Add entry describing the new quality category and sub-category tagging convention
python/ql/src/**/*.ql	Add quality tag and assign one or more sub-category tags (reliability, maintainability, correctness, etc.) to each Python query
python/ql/integration-tests/query-suite/python-code-quality.qls.expected	Update the expected list of queries included in the python-code-quality test suite

Comments suppressed due to low confidence (2)

python/ql/integration-tests/query-suite/python-code-quality.qls.expected:1

• Paths in this expected list are missing the python/ prefix (python/ql/src/...) and won’t match the actual file locations; please restore the full relative path.

ql/src/Classes/ConflictingAttributesInBaseClasses.ql

[tausbn]

I've made a few comments/suggestions here and there, but overall this looks good to me. 👍

[tausbn]

Could add performance here.

[tausbn]

Let's get it in! 👍