JS: Improve alert messages of js/incomplete-sanitization#19953
Closed
Napalys wants to merge 4 commits intogithub:mainfrom
Closed
JS: Improve alert messages of js/incomplete-sanitization#19953Napalys wants to merge 4 commits intogithub:mainfrom
js/incomplete-sanitization#19953Napalys wants to merge 4 commits intogithub:mainfrom
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| if node instanceof DataFlow::RegExpConstructorInvokeNode | ||
| then result = "/" + node.(DataFlow::RegExpConstructorInvokeNode).getRoot() + "/" | ||
| else result = node.toString() | ||
| if exists(node.getStringValue()) then result = node.toString() else result = "this node" |
Check warning
Code scanning / CodeQL
Using 'toString' in query logic Warning
Contributor
Author
There was a problem hiding this comment.
node.toString() seems to give a bit more user friendly messages compared to node.getStringValue()
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improves alert message clarity for the
js/incomplete-sanitizationquery by referencingthis nodewhen no string value is present. Replaces string concatenation with placeholders for cleaner output.