Make a proper shared library out of the concept related libraries #19984
Merged
jketema merged 9 commits intogithub:mainfrom Jul 17, 2025
Merged
Make a proper shared library out of the concept related libraries #19984jketema merged 9 commits intogithub:mainfrom
jketema merged 9 commits intogithub:mainfrom
Conversation
github-actions
bot
added
JS
Python
Ruby
Rust
jketema
force-pushed
the
jketema/sec-shared
branch
4 times, most recently
from
eb7ba6b to
05a28b9
Compare
jketema
force-pushed
the
jketema/sec-shared
branch
from
05a28b9 to
430eeea
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
jketema
force-pushed
the
jketema/sec-shared
branch
3 times, most recently
from
05f694f to
33f874e
Compare
jketema
force-pushed
the
jketema/sec-shared
branch
from
33f874e to
1995870
Compare
jketema
changed the title
6 tasks
Contributor
|
I reviewed all of the DCA runs and nothing seems to be amiss. 👍 |
jketema
force-pushed
the
jketema/sec-shared
branch
from
2d20b9a to
24bea73
Compare
The import should not have been private, because we want users to still be able to import this file and have access to the crypto algorithms.
aschackmull
approved these changes
Jul 16, 2025
geoffw0
approved these changes
Jul 16, 2025
Contributor
geoffw0
left a comment
geoffw0
left a comment
There was a problem hiding this comment.
Looks great, I was surprised how little per-language customization is needed on things like ConceptsShared - but I guess they're build atop shared dataflow.
Contributor
Author
|
Going ahead and merging this. The coding standards failures are not related to these changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Observe that to turn the
ConceptsShared.qllinto a parameterized module I had to introduce(see https://github.com/github/codeql/pull/19984/files#diff-ab7ead61741aa4309d3f7c41942166168e0c46d9fe16b1f6e8089e251eba90caR20) This has an impact on some places where
ConceptsShared.qll, as it becomes impossible to useextendsin various places. So I opted for usinginstanceofinstead. The latter might explain some of the changes in stage timings visible in the DCA results. Overall analysis time does not seem to be impacted though.