Rust: Remove restriction in PathTypeMention#20173
Merged
hvitved merged 1 commit intogithub:mainfrom Aug 6, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR removes a restriction in the PathTypeMention class by eliminating the relevantPathTypeMention predicate that limited which paths could be considered as type mentions during type inference. The change broadens the scope of paths that can be analyzed as type mentions.
Key changes:
- Removed the
relevantPathTypeMentionpredicate and its associated filtering logic - Simplified the
PathTypeMentionclass to extend directly fromTypeMentionandPath - Added visibility modifiers to improve encapsulation
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| TypeMention.qll | Removed restriction predicate and simplified PathTypeMention class definition, added pragma and visibility modifiers |
| Type.qll | Changed implTraitTypeParam predicate from public to private visibility |
geoffw0
approved these changes
Aug 6, 2025
Contributor
geoffw0
left a comment
geoffw0
left a comment
There was a problem hiding this comment.
Agreed, DCA looks fine so this seems like a good simplification.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #20094 (comment).
DCA looks fine.