Python: Add support for Psycopg2 database connection pools#20276
Merged
Python: Add support for Psycopg2 database connection pools#20276
Conversation
Our current modelling only treated `psycopg2` insofar as it implemented PEP 249 (which does not define any notion of connection pool), which meant we were missing database connections that arose from such pools. With these changes, we add support for the three classes relating to database pools that are defined in `psycopg2`. (Note that `getAnInstance` automatically looks at subclasses, which means this should also handle cases where the user has defined a new subclass that inherits from one of these three classes.)
joefarebrother
previously approved these changes
Aug 25, 2025
Contributor
joefarebrother
left a comment
joefarebrother
left a comment
There was a problem hiding this comment.
Looks good, though I might add one or two unit test cases somewhere to cover the additional models.
Contributor
Author
Yup, I'm working on some tests now. I just wanted to put the code up ASAP so it could help the people who reported the issue to me. |
Member
And it definitely did, thank you so much for the great work! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Our current modelling only treated
psycopg2insofar as it implemented PEP 249 (which does not define any notion of connection pool), which meant we were missing database connections that arose from such pools.With these changes, we add support for the three classes relating to database pools that are defined in
psycopg2. (Note thatgetAnInstanceautomatically looks at subclasses, which means this should also handle cases where the user has defined a new subclass that inherits from one of these three classes.)