C++: Add ComPtr conversion operators#20310
Merged
jketema merged 7 commits intogithub:mainfrom Aug 29, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds conversion operators to the ComPtr model for Microsoft WRL (Windows Runtime Library) to improve data flow tracking. The models enable tracking of taint through ComPtr operations, which is important for security analysis of Windows C++ applications.
Key changes:
- Adds new models for ComPtr assignment operators and dereference operators
- Adds ComPtrRef class models for address-of operations
- Improves taint flow detection through smart pointer conversions
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
ComPtr.model.yml |
Adds assignment operator models for ComPtr including templated and move assignment operators |
ComPtrRef.model.yml |
New model file for ComPtrRef class with conversion and dereference operators |
atl.cpp |
Adds test cases for new ComPtr operators and conversion scenarios |
*.expected |
Test result updates reflecting the new models and improved taint flow detection |
jketema
approved these changes
Aug 28, 2025
Contributor
jketema
left a comment
There was a problem hiding this comment.
Looks sensible. So I'm happy if DCA is happy.
Contributor
|
DCA was uneventful. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This model sadly isn't complete because our MaD parsing doesn't yet support using templates in the name of the function. This is necessary for stuff like:
which happens a lot for the
ComPtrRefclass (for example here). I plan to tackle that as a follow-up and then we can add the remaining models.Commit-by-commit review recommended. I also spotted an incorrect model that I added in #20301 which I fixed in b4cc17f (and Copilot spotted even more stuff like that which I fixed in b9cd7a8). Generally, it's always a bug to have an occurrence of
@in the input column, but not in the output column (or vice versa) of a value-preserving summary since that would correspond to some kind of conflation.