JS: Do not override AST methods in React model#20322
Merged
asgerf merged 2 commits intogithub:mainfrom Sep 10, 2025
Merged
Conversation
asgerf
force-pushed
the
js/react-no-override
branch
from
2f4b18b to
ed3283b
Compare
asgerf
force-pushed
the
js/react-no-override
branch
from
ed3283b to
ca393a9
Compare
Contributor
Author
|
The three projects that are failing on DCA are due to a problem with SARIF exports that is not related to this PR |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR removes problematic AST method overrides in the React model to fix overlay locality issues. The changes convert the SharedReactPreactClassComponent from multiple inheritance to using the instanceof pattern and add explicit delegation methods.
- Replaces multiple inheritance with
instanceof ClassDefinitionpattern - Adds explicit delegation methods (
getSuperClass,getConstructor) to the shared component class - Updates all method calls to use explicit delegation instead of inherited methods
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Napalys
approved these changes
Sep 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The React model contained an override of
ClassDefinition.getInstanceMethod, which simply forwarded to the same predicate, but was needed at the time to avoid ambiguous inheritance.This PR removes the problematic dependency, as it was blocking overlay locality.