C++: Fix some Ql4Ql violations (crypto).#20350
Merged
jketema merged 1 commit intogithub:mainfrom Sep 4, 2025
Merged
Conversation
michaelnebel
changed the title
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes various Ql4Ql violations across multiple CodeQL library files in the C++ experimental cryptography module. The changes address code quality issues including parameter documentation, spelling corrections, naming conventions, and module naming improvements.
Key changes include:
- Fixed spelling errors in comments ("postive" → "positive", "deafult" → "default")
- Corrected parameter name in documentation ("onExpr" → "inExpr")
- Renamed module to follow naming conventions (added "Config" suffix)
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| PassthroughFunction.qll | Fixed parameter name in documentation comment |
| DataBuilders.qll | Corrected spelling error in comment |
| CryptoFunction.qll | Corrected spelling error in comment |
| OpenSSL.qll | Renamed module to follow naming conventions |
| CryptoArtifact.qll | Fixed spelling error in comment |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| * users can then extrapolatae the matching algorithm from the alg sink to the keygen | ||
| */ | ||
| module EVP_PKEY_CTX_Ptr_Source_to_KeyGenOperationWithNoSize implements DataFlow::ConfigSig { | ||
| module EVP_PKEY_CTX_Ptr_Source_to_KeyGenOperationWithNoSizeConfig implements DataFlow::ConfigSig { |
Check warning
Code scanning / CodeQL
Acronyms should be PascalCase/camelCase Warning
aschackmull
approved these changes
Sep 4, 2025
jketema
approved these changes
Sep 4, 2025
Contributor
jketema
left a comment
jketema
left a comment
There was a problem hiding this comment.
I had a brief chat with @bdrodes, whose also working on this code. This is fine from their perspective.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix some Ql4Ql violations based on the following checks
ql/field-only-used-in-charpredql/could-be-castql/counting-to-zeroql/dataflow-module-naming-conventionql/if-with-noneql/missing-parameter-qldocql/misspelling