Closed
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull Request Overview
Refactors the JavaScript module import system to improve overlay locality by making getImportedModuleNode() local while keeping getImportedModule() global. This enables better handling of non-standard default import semantics.
- Introduces
isDefaultImport()andgetImportedModuleNodeIfUnambiguous()predicates for better default import handling - Refactors
getImportedModuleNode()to be overlay-local compatible - Updates API graph logic to use the unambiguous variant where needed
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| javascript/ql/lib/semmle/javascript/Modules.qll | Adds new predicates and refactors getImportedModuleNode() documentation and signature |
| javascript/ql/lib/semmle/javascript/ES2015Modules.qll | Implements default import detection and updates module node resolution logic |
| javascript/ql/lib/semmle/javascript/ApiGraphs.qll | Updates API graph tracking to use unambiguous module node resolution |
Comment on lines
+228
to
+235
| pragma[nomagic] | ||
| final DataFlow::Node getImportedModuleNodeIfUnambiguous() { | ||
| result = this.getImportedModuleNode() and | ||
| not ( | ||
| this.isDefaultImport() and | ||
| this.getImportedModule().(ES2015Module).hasBothNamedAndDefaultExports() | ||
| ) | ||
| } |
There was a problem hiding this comment.
[nitpick] The getImportedModuleNodeIfUnambiguous() method lacks documentation explaining the pragma[nomagic] directive and why it's necessary for this predicate.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For overlay locality, we want
Import.getImportedModuleNode()to be local, without necessarily makingImport.getImportedModule()local.This means
getImportedModuleNode()shouldn't depend ongetImportedModule(), but currently some logic for dealing with non-standarddefaultimport semantics relies on it.This PR refactors
getImportedModuleNode()so it can beoverlay[local], and introducesgetImportedModuleNodeIfUnambiguous()which isoverlay[global]and performs some extra checks to avoid incorrect data flow. Most use-cases can just continue usinggetImportedModuleNode().