Rust: Upgrade to rust-analyzer 0.0.301#20408
Conversation
github-actions
bot
added
documentation
Ruby
Rust
paldepind
force-pushed
the
rust/update-rust-analyzer
branch
from
6e07d4b to
4e1c4a9
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR upgrades rust-analyzer dependencies from version 0.0.300 to 0.0.301, updating the core Rust extractor components and related dependencies. The update appears to have gone smoothly, with the note that Ruby extractor changes were reverted due to compatibility issues.
Key changes:
- Updates all
ra_ap_*(rust-analyzer API) dependencies from 0.0.300 to 0.0.301 - Updates various Rust ecosystem dependencies (proc-macro2, syn, chrono, etc.)
- Updates Bazel build files to reflect new dependency versions
Reviewed Changes
Copilot reviewed 162 out of 163 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
shared/typeinference/codeql/typeinference/internal/TypeScraps.md |
Added new code snippets for type inference signature modules |
shared/tree-sitter-extractor/Cargo.toml |
Updated dependency versions for tracing-subscriber, rayon, regex, and chrono |
rust/extractor/macros/Cargo.toml |
Updated syn dependency from 2.0.104 to 2.0.106 |
rust/extractor/Cargo.toml |
Updated clap and all rust-analyzer dependencies to 0.0.301, plus other minor version bumps |
rust/ast-generator/Cargo.toml |
Updated proc-macro2 and ra_ap_stdx to latest versions |
misc/bazel/3rdparty/tree_sitter_extractors_deps/defs.bzl |
Comprehensive update of Bazel dependency definitions with new version labels |
| Multiple BUILD files | Updated version numbers and dependency references throughout Bazel build configuration |
That's because database caching was enabled; I have started a new run with caching disabled. |
|
Oh, I see. Thanks! The second DCA run seems good as well. |
|
Looks like this has a positive impact on extraction time: https://github.com/github/codeql-dca-main/blob/data/hvitved/pr-20408-4e1c4a__nightly__nightly/reports/summaries/time.theme.md#database-build-time-per-source |
| [dependencies] | ||
| tree-sitter = ">= 0.23.0" | ||
| tree-sitter-embedded-template = "0.25.0" | ||
| tree-sitter-embedded-template = "0.23.2" |
There was a problem hiding this comment.
@paldepind I guess upgrading tree-sitter-embedded-template caused problem in the ruby extractor. Perhaps we can bump the versions of the other dependencies and only revert the upgrade of tree-sitter-embedded-template?
There was a problem hiding this comment.
The changes in 0.25 don't look to exciting, but I guess the update of the underlying tree-sitter library may cause problems. Having multiple versions of tree-sitter in the dependency hierarchy can lead to annoying clashes and error messages like type Language does not match type Language.
There was a problem hiding this comment.
Thanks, just make an issue for the Ruby team to have a look into updating tree-sitter-embedded-template and tree-sitter.
There was a problem hiding this comment.
The DCA results for the upgraded Ruby dependencies are. How do they look to you @aibaars?
There was a problem hiding this comment.
I would have expected to see no differences, the updated dependencies (chrono, regex, tracing-subscriber and rayon) should have little effect. Not sure if the report is just showing "normal" noise. @hvitved what do you think?
There was a problem hiding this comment.
I think both DCA runs were missing the -X change-ql-submodule-in-semmle-code=true flag; I'll start new runs.
There was a problem hiding this comment.
Both new DCA runs look fine.
shared/typeinference/codeql/typeinference/internal/TypeScraps.md
Outdated
Show resolved
Hide resolved
paldepind
force-pushed
the
rust/update-rust-analyzer
branch
from
4e1c4a9 to
19c529e
Compare
|
I think this is ready for the final 👍. |
3 participants
This seems to have gone pretty smoothly.
I had to revert the changes to the Ruby extractor's Cargo file as updating those caused problems.
DCA is uneventful.