Go: Retrofit the change log to mention Go 1.25#20422
Merged
jketema merged 2 commits intogithub:mainfrom Sep 12, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the Go library's change log documentation to mention support for Go 1.25. The change adds a "Minor Analysis Improvements" section noting Go 1.25 support, replacing the previous "No user-facing changes" entries.
- Added Go 1.25 support announcement to change log entries
- Replaced placeholder "No user-facing changes" text with meaningful content
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| go/ql/lib/change-notes/released/4.3.2.md | Added Go 1.25 support note under Minor Analysis Improvements |
| go/ql/lib/CHANGELOG.md | Updated version 4.3.2 section to include Go 1.25 support announcement |
This can only be a minor change (or something similar) to stay within the semantic versioning contraints. This is because only the patch version of the Go ql library pack was bumped during the release. Since there were no new language features in Go 1.25, this might also be the most accurate choice here.
mbg
approved these changes
Sep 12, 2025
Member
mbg
left a comment
mbg
left a comment
There was a problem hiding this comment.
I think "Minor Analysis" is what we'd usually choose, unless the version upgrade results in some breaking change.
Contributor
Author
I just looked at the 1.24 change note, and that had a "major". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This can only be a minor change (or something similar) to stay within the semantic versioning contraints. This is because only the patch version of the Go ql library pack was bumped during the release. Since there were no new language features in Go 1.25, this might also be the most accurate choice here.